about summary refs log tree commit diff
diff options
context:
space:
mode:
authorFranck Cuny <franck@fcuny.net>2022-08-10 17:42:38 -0700
committerFranck Cuny <franck@fcuny.net>2022-08-10 17:43:16 -0700
commitf166a49698ee17ffc7af1fd16d6498ffcefc20fd (patch)
tree2073f890cf92308c629a524880c5bf70179d5459
parentfeat(ops/tf): script to create GCP service accounts and set roles (diff)
downloadworld-f166a49698ee17ffc7af1fd16d6498ffcefc20fd.tar.gz
fix(ops/tf): remove comments
Change-Id: Ifb970bc6835fbc0de1943349739524331b6dba76
Reviewed-on: https://cl.fcuny.net/c/world/+/712
Reviewed-by: Franck Cuny <franck@fcuny.net>
Tested-by: CI
-rwxr-xr-xops/tf-gcs-init/tf-gcs-init.sh8
1 files changed, 0 insertions, 8 deletions
diff --git a/ops/tf-gcs-init/tf-gcs-init.sh b/ops/tf-gcs-init/tf-gcs-init.sh
index f675381..3a8f2b3 100755
--- a/ops/tf-gcs-init/tf-gcs-init.sh
+++ b/ops/tf-gcs-init/tf-gcs-init.sh
@@ -6,14 +6,6 @@
 # impersonate the 'terraform' service account, so we don't need to
 # generate keys. The roles for the SA are also set.
 
-# TODO:
-# gcloud projects add-iam-policy-binding fcuny-backups --member="serviceAccount:terraform@fcuny-homelab.iam.gserviceaccount.com" --role="roles/viewer"
-# gcloud projects add-iam-policy-binding fcuny-backups
-# --member="serviceAccount:terraform@fcuny-homelab.iam.gserviceaccount.com"
-# --role="roles/owner"
-# I need to perform some actions on all the projects, not just the
-# first one, need to expand the script for that part.
-
 set -u
 set -e
 set -o pipefail