summary refs log tree commit diff
diff options
context:
space:
mode:
authorfranck cuny <franck@lumberjaph.net>2010-07-30 10:18:06 +0200
committerfranck cuny <franck@lumberjaph.net>2010-07-30 10:18:06 +0200
commit2aaa309a8b8509481e38601cbe9d1cf802091a45 (patch)
treedc24aa5ae16172f2c8897615495155cba1b0c642
parentfix call to _fail_method (diff)
parentlog helper improved (diff)
downloadpresque-worker-2aaa309a8b8509481e38601cbe9d1cf802091a45.tar.gz
Merge branch 'master' of github.com:franckcuny/presque-worker
* 'master' of github.com:franckcuny/presque-worker:
  log helper improved
  avoid unfinished test
  sub log(msg[,level]) helper added
-rw-r--r--lib/presque/worker/Role/Logger.pm35
-rw-r--r--t/10_basic.t7
2 files changed, 16 insertions, 26 deletions
diff --git a/lib/presque/worker/Role/Logger.pm b/lib/presque/worker/Role/Logger.pm
index ff0090e..6c286c4 100644
--- a/lib/presque/worker/Role/Logger.pm
+++ b/lib/presque/worker/Role/Logger.pm
@@ -42,46 +42,35 @@ sub _load_log_engine {
 
 before start => sub {
     my $self = shift;
-
-    $self->logger->log(
-        level   => 'info',
-        message => "presque worker ["
-          . $self->worker_id
-          . "] : start to listen for "
-          . $self->queue_name
-    );
+    $self->log( 'start to listen for ' . $self->queue_name );
 };
 
 before work => sub {
     my $self = shift;
-    $self->logger->log(
-        level   => 'debug',
-        message => $self->worker_id . ' start to work',
-    );
+    $self->log( 'start to work', 'debug' );
 };
 
 before _shutdown => sub {
     my $self = shift;
-    $self->logger->log(
-        level   => 'info',
-        message => 'worker ' . $self->worker_id . ' shuting down'
-    );
+    $self->log( 'shutting down' );
 };
 
 before _graceful_shutdown => sub {
     my $self = shift;
-    $self->logger->log(
-        level   => 'info',
-        message => 'worker ' . $self->worker_id . ' kill child'
-    );
+    $self->log( 'kill child' );
 };
 
 before _kill_child => sub {
     my $self = shift;
+    $self->log( 'shutting down gracefuly' );
+};
+
+sub log {
+    my( $self, $msg, $level ) = @_;
     $self->logger->log(
-        level   => 'info',
-        message => 'worker ' . $self->worker_id . ' shuting down gracefuly'
+        message => '['.$self->worker_id.'] '.$msg,
+        level   => $level || 'info',
     );
-};
+}
 
 1;
diff --git a/t/10_basic.t b/t/10_basic.t
index 0754f66..51b029f 100644
--- a/t/10_basic.t
+++ b/t/10_basic.t
@@ -5,9 +5,10 @@ use Test::More;
 
 use presque::worker;
 
-my $w = presque::worker->new_with_traits( { traits => [qw/foo/] } );
-my $w2 = presque::worker->new();
+#TODO
+#my $w = presque::worker->new_with_traits( { traits => [qw/foo/] } );
+#my $w2 = presque::worker->new();
 
 ok 1;
 
-done_testing;
\ No newline at end of file
+done_testing;