From adf06fefd3f23850941d706a0765c8ff9a6fa4b4 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 11:34:38 +0200 Subject: s/with_caller/with_meta/, move code into roles --- lib/MooseX/Net/API.pm | 504 ++++++++++---------------------------------------- 1 file changed, 99 insertions(+), 405 deletions(-) (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API.pm b/lib/MooseX/Net/API.pm index 634416f..b0e02b8 100644 --- a/lib/MooseX/Net/API.pm +++ b/lib/MooseX/Net/API.pm @@ -1,355 +1,56 @@ package MooseX::Net::API; -use URI; -use Try::Tiny; -use HTTP::Request; - use Moose; use Moose::Exporter; -use MooseX::Net::API::Error; - -use MooseX::Net::API::Meta::Class; -use MooseX::Net::API::Meta::Method; - -use MooseX::Net::API::Role::Serialize; -use MooseX::Net::API::Role::Deserialize; - -our $VERSION = '0.10'; - -my $list_content_type = { - 'json' => 'application/json', - 'yaml' => 'text/x-yaml', - 'xml' => 'text/xml', -}; - -my ( $do_auth, $base_url, $auth_method, $deserialize_method ); +our $VERSION = '0.13'; Moose::Exporter->setup_import_methods( - with_caller => [qw/net_api_method net_api_declare/], ); + with_meta => [qw/net_api_method net_api_declare/], + also => [qw/Moose/] +); -sub init_meta { - my ( $me, %options ) = @_; - - my $for = $options{for_class}; - Moose::Util::MetaRole::apply_metaroles( - for_class => $for, - metaclass_roles => ['MooseX::Net::API::Meta::Class'], - ); +sub net_api_method { + my $meta = shift; + my $name = shift; + $meta->add_net_api_method($name, @_); } sub net_api_declare { - my $caller = shift; - my $name = shift; - my %options = @_; - - my $class = Moose::Meta::Class->initialize($caller); - - $class->add_attribute( - 'api_base_url', - is => 'rw', - isa => 'Str', - lazy => 1, - default => delete $options{base_url} || '' - ); - - if ( !$options{format} ) { - die MooseX::Net::API::Error->new( - reason => "format is missing in your api declaration" ); - } - elsif ( !$list_content_type->{ $options{format} } ) { - die MooseX::Net::API::Error->new( - reason => "format is not recognised. It must be " - . join( " or ", keys %$list_content_type ) ); - } - else { - $class->add_attribute( - 'api_format', - is => 'ro', - isa => 'Str', - lazy => 1, - default => delete $options{format} - ); - } - - if ( !$options{format_mode} ) { - die MooseX::Net::API::Error->new( - reason => "format_mode is not set" ); - } - elsif ( $options{format_mode} !~ /^(?:append|content\-type)$/ ) { - die MooseX::Net::API::Error->new( - reason => "format_mode must be append or content-type" ); - } - else { - $class->add_attribute( - 'api_format_mode', - is => 'ro', - isa => 'Str', - lazy => 1, - default => delete $options{format_mode} - ); - } - - if ( !$options{useragent} ) { - _add_useragent($class); - } - else { - my $method = $options{useragent}; - if ( ref $method ne 'CODE' ) { - die MooseX::Net::API::Error->new( - reason => "useragent must be a CODE ref" ); - } - else { - _add_useragent( $class, delete $options{useragent} ); - } - } - - if ( $options{authentication} ) { - $do_auth = delete $options{authentication}; - } - - if ( $options{username} ) { - $class->add_attribute( - 'api_username', - is => 'ro', - isa => 'Str', - lazy => 1, - default => delete $options{username} - ); - if ( $options{password} ) { - $class->add_attribute( - 'api_password', - is => 'ro', - isa => 'Str', - lazy => 1, - default => delete $options{password} - ); - } - } - if ( $options{authentication_method} ) { - $auth_method = delete $options{authentication_method}; - } - - if ( $options{deserialisation} ) { - $deserialize_method = delete $options{deserialize_order}; - } - else { - MooseX::Net::API::Role::Deserialize->meta->apply( $caller->meta ); - } - - if ( $options{serialisation} ) { - $deserialize_method = delete $options{serialize_order}; - } - else { - MooseX::Net::API::Role::Serialize->meta->apply( $caller->meta ); - } + my $meta = shift; + my $name = shift; + $meta->add_net_api_declare($name, @_); } -sub net_api_method { - my $caller = shift; - my $name = shift; - my %options = ( authentication => $do_auth, @_ ); - - if ( !$options{params} && $options{required} ) { - die MooseX::Net::API::Error->new( reason => - "you can't require a param that have not been declared" ); - } - - if ( $options{required} ) { - foreach my $required ( @{ $options{required} } ) { - die MooseX::Net::API::Error->new( reason => - "$required is required but is not declared in params" ) - if ( !grep { $_ eq $required } @{ $options{params} } ); - } - } +sub init_meta { + my ($class, %options) = @_; - my $class = Moose::Meta::Class->initialize($caller); - - my $code; - if ( !$options{code} ) { - $code = sub { - my $self = shift; - my %args = @_; - - my $meta = $self->meta; - - if ( $auth_method && !$meta->find_method_by_name($auth_method) ) { - die MooseX::Net::API::Error->new( reason => - "you provided $auth_method as an authentication method, but it's not available in your object" - ); - } - - if ( $deserialize_method - && !$meta->find_method_by_name($deserialize_method) ) - { - die MooseX::Net::API::Error->new( reason => - "you provided $deserialize_method for deserialisation, but the method is not available in your object" - ); - } - - # check if there is no undeclared param - foreach my $arg ( keys %args ) { - if ( !grep { $arg eq $_ } @{ $options{params} } ) { - die MooseX::Net::API::Error->new( - reason => "$arg is not declared as a param" ); - } - } - - # check if all our params declared as required are present - foreach my $required ( @{ $options{required} } ) { - if ( !grep { $required eq $_ } keys %args ) { - die MooseX::Net::API::Error->new( reason => - "$required is declared as required, but is not present" - ); - } - } - - my $path = $options{path}; - - # replace all args in the url - while ( $path =~ /\$(\w+)/ ) { - my $match = $1; - if ( my $value = delete $args{$match} ) { - $path =~ s/\$$match/$value/; - } - } - - $path .= '/' if ( $self->api_base_url !~ m!/^! ); - my $url = $self->api_base_url . $path; - - my $format = $self->api_format(); - $url .= "." . $format if ( $self->api_format_mode() eq 'append' ); - my $uri = URI->new($url); - - my $res = _request( $self, $format, \%options, $uri, \%args ); - if ( $options{expected} ) { - if ( !grep { $_ eq $res->code } @{ $options{expected} } ) { - die MooseX::Net::API::Error->new( - reason => "unexpected code", - http_error => $res - ); - } - } - - my $content_type = $res->headers->{"content-type"}; - $content_type =~ s/(;.+)$//; - - my @deserialize_order - = ( $content_type, $format, keys %$list_content_type ); - - my $content; - if ($deserialize_method) { - $content = $self->$deserialize_method( $res->content, - @deserialize_order ); - } - else { - $content = $self->_do_deserialization( $res->content, - @deserialize_order ); - } - - if ( $res->is_success ) { - if (wantarray) { - return ( $content, $res ); - } - else { - return $content; - } - } - - die MooseX::Net::API::Error->new( - http_error => $res, - reason => $content - ); - }; - } - else { - $code = $options{code}; - } + my $for = $options{for_class}; + Moose->init_meta(%options); - $class->add_method( - $name, - MooseX::Net::API::Meta::Method->new( - name => $name, - package_name => $caller, - body => $code, - %options, - ), + my $meta = Moose::Util::MetaRole::apply_metaroles( + for_class => $for, + metaclass_roles => ['MooseX::Net::API::Meta::Class'], ); - $class->_add_api_method($name); -} -sub _add_useragent { - my $class = shift; - my $code = shift; - - if ( !$code ) { - try { require LWP::UserAgent; } - catch { - die MooseX::Net::API::Error->new( reason => - "no useragent defined and LWP::UserAgent is not available" - ); - }; - - $code = sub { - my $ua = LWP::UserAgent->new(); - $ua->agent("MooseX::Net::API/$VERSION (Perl)"); - $ua->env_proxy; - return $ua; - }; - } - $class->add_attribute( - 'api_useragent', - is => 'rw', - isa => 'Any', - lazy => 1, - default => $code, + Moose::Util::MetaRole::apply_base_class_roles( + for => $for, + roles => [ + qw/ + MooseX::Net::API::Role::UserAgent + MooseX::Net::API::Role::Format + MooseX::Net::API::Role::Authentication + MooseX::Net::API::Role::Serialization + MooseX::Net::API::Role::Request + / + ], ); -} - -sub _request { - my ( $self, $format, $options, $uri, $args ) = @_; - - my $req; - my $method = $options->{method}; - if ( $method =~ /^(?:GET|DELETE)$/ || $options->{params_in_url} ) { - $uri->query_form(%$args); - $req = HTTP::Request->new( $method => $uri ); - } - elsif ( $method =~ /^(?:POST|PUT)$/ ) { - $req = HTTP::Request->new( $method => $uri ); - my $content = $self->_do_serialization( $args, $format ); - $req->content($content); - } - else { - die MooseX::Net::API::Error->new( - reason => "$method is not defined" ); - } - - $req->header( 'Content-Type' => $list_content_type->{$format} ) - if $self->api_format_mode eq 'content-type'; - - if ( $do_auth || $options->{authentication} ) { - if ($auth_method) { - $req = $self->$auth_method($req); - } - else { - $req = _do_authentication( $self, $req ); - } - } - - return $self->api_useragent->request($req); -} - -sub _do_authentication { - my ( $caller, $req ) = @_; - $req->headers->authorization_basic( $caller->api_username, - $caller->api_password ) - if ( $caller->api_username && $caller->api_password ); - return $req; + $meta; } 1; + __END__ =head1 NAME @@ -358,58 +59,57 @@ MooseX::Net::API - Easily create client for net API =head1 SYNOPSIS - package My::Net::API; - use Moose; - use MooseX::Net::API; - - # we declare an API, the base_url is http://exemple.com/api - # the format is json and it will be happened to the query - # You can set base_url later, calling $obj->api_base_url('http://..') - net_api_declare my_api => ( - base_url => 'http://exemple.com/api', - format => 'json', - format_api => 'append', - ); + package My::Net::API; + use MooseX::Net::API; - # calling $obj->foo will call http://exemple.com/api/foo?user=$user&group=$group - net_api_method foo => ( - description => 'this get foo', - method => 'GET', - path => '/foo/', - params => [qw/user group/], - required => [qw/user/], - ); + # we declare an API, the base_url is http://exemple.com/api + # the format is json and it will be append to the query + # You can set api_base_url later, calling $obj->api_base_url('http://..') + net_api_declare my_api => ( + api_base_url => 'http://exemple.com/api', + api_format => 'json', + api_format_mode => 'append', + ); - # you can create your own useragent - net_api_declare my_api => ( - ... - useragent => sub { - my $ua = LWP::UserAgent->new; - $ua->agent('MyUberAgent/0.23'); - return $ua - }, - ... - ); + # declaring a users method + # calling $obj->users will call http://exemple.com/api/users?country=france + net_api_method users => ( + description => 'this get a list of users', + method => 'GET', + path => '/users/', + params => [qw/country/], + ); - # if the API require authentification, the module will handle basic - # authentication for you - net_api_declare my_api => ( - ... - authentication => 1, - ... - ); + # you can create your own useragent (it must be a LWP::UserAgent object) + net_api_declare my_api => ( + ... + useragent => sub { + my $ua = LWP::UserAgent->new; + $ua->agent('MyUberAgent/0.23'); + return $ua + }, + ... + ); - # if the authentication is more complex, you can delegate to your own method + # if the API require authentification, the module will handle basic + # authentication for you + net_api_declare my_api => ( + ... + authentication => 1, + ... + ); + + # if the authentication is more complex, you can delegate to your own method - 1; + 1; - my $obj = My::Net::API->new(); - $obj->api_base_url('http://...'); - $obj->foo(user => $user); + my $obj = My::Net::API->new(); + $obj->api_base_url('http://...'); + $obj->foo(user => $user); =head1 DESCRIPTION -MooseX::Net::API is module to help to easily create a client for a web API. +MooseX::Net::API is a module to help to easily create a client for a web API. This module is heavily inspired by what L does. B @@ -420,37 +120,33 @@ B =item B - net_api_declare backtype => ( - base_url => 'http://api....', - format => 'json', - format_mode => 'append', - ); + net_api_declare backtype => ( + base_url => 'http://api....', + format => 'json', + format_mode => 'append', + ); =over 2 -=item B (required) +=item B -The base url for all the API's calls. This will add an B -attribut to your class. +The base url for all the API's calls. This will add an B attribut to your class. Can be set at the object creation or before calling an API method. If no api_base_url is defined, the method will die. -=item B (required, must be either xml, json or yaml) +=item B (required, must be either xml, json or yaml) -The format for the API's calls. This will add an B attribut to -your class. +The format for the API's calls. This will add an B attribut to your class. -=item B (required, must be 'append' or 'content-type') +=item B (required, must be 'append' or 'content-type') -How the format is handled. B will add B<.json> to the query, -B will add the content-type information to the header of the -request. +How the format is handled. B will add B<.json> to the query, B will add the content-type information to the header of the request. =item B (optional, by default it's a LWP::UserAgent object) - useragent => sub { - my $ua = LWP::UserAgent->new; - $ua->agent( "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1"); - return $ua; - }, + useragent => sub { + my $ua = LWP::UserAgent->new; + $ua->agent( "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1"); + return $ua; + } =item B (optional) @@ -458,8 +154,7 @@ This is a boolean to tell if we must authenticate to use this API. =item B (optional) -The default authentication method only set an authorization header using the -Basic Authentication Scheme. You can write your own authentication method: +The default authentication method only set an authorization header using the Basic Authentication Scheme. You can write your own authentication method: net_api_declare foo => ( ... @@ -493,20 +188,20 @@ path of the query. If you defined your path and params like this - net_api_method user_comments => ( - ... - path => '/user/$user/list/$date/', - params => [qw/user date foo bar/], - ... - ); + net_api_method user_comments => ( + ... + path => '/user/$user/list/$date/', + params => [qw/user date foo bar/], + ... + ); and you call - $obj->user_comments(user => 'franck', date => 'today', foo => 1, bar => 2); + $obj->user_comments(user => 'franck', date => 'today', foo => 1, bar => 2); the url generetad will look like - /user/franck/list/today/?foo=1&bar=2 + /user/franck/list/today/?foo=1&bar=2 =item B [arrayref] @@ -522,8 +217,7 @@ should we do an authenticated call =item B (optional) -When you do a post, the content may have to be sent as arguments in the url, -and not as content in the header. +When you do a post, the content may have to be sent as arguments in the url, and not as content in the header. =back -- cgit 1.4.1 From 14a0f6b2b3ae8a30dbf5ee0c069acc37a3472786 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 11:34:57 +0200 Subject: use JSON, add POD --- lib/MooseX/Net/API/Error.pm | 35 +++++++++++++++++++++++++++++++++-- 1 file changed, 33 insertions(+), 2 deletions(-) (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API/Error.pm b/lib/MooseX/Net/API/Error.pm index 0542613..a710205 100644 --- a/lib/MooseX/Net/API/Error.pm +++ b/lib/MooseX/Net/API/Error.pm @@ -1,12 +1,12 @@ package MooseX::Net::API::Error; use Moose; -use JSON::XS; +use JSON; use Moose::Util::TypeConstraints; use overload '""' => \&error; subtype error => as 'Str'; -coerce error => from 'HashRef' => via { encode_json $_}; +coerce error => from 'HashRef' => via { JSON::encode_json $_}; has http_error => ( is => 'ro', @@ -31,3 +31,34 @@ sub error { 1; __END__ + +=head1 NAME + +MooseX::Net::API::Error + +=head1 SYNOPSIS + + MooseX::Net::API::Error->new(reason => "'useragent' is required"); + +or + + MooseX::Net::API::Error->new() + +=head1 DESCRIPTION + +=head1 AUTHOR + +franck cuny Efranck@lumberjaph.netE + +=head1 SEE ALSO + +=head1 LICENSE + +Copyright 2009, 2010 by Linkfluence + +http://linkfluence.net + +This library is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut -- cgit 1.4.1 From 31baf7b70e2f7c63476685afe18fc7c4697274d4 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 11:35:13 +0200 Subject: meta class with role --- lib/MooseX/Net/API/Meta/Class.pm | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API/Meta/Class.pm b/lib/MooseX/Net/API/Meta/Class.pm index e4bed0c..376578d 100644 --- a/lib/MooseX/Net/API/Meta/Class.pm +++ b/lib/MooseX/Net/API/Meta/Class.pm @@ -1,25 +1,10 @@ package MooseX::Net::API::Meta::Class; use Moose::Role; -use Moose::Meta::Class; -use MooseX::Types::Moose qw(Str ArrayRef ClassName Object); -has local_api_methods => ( - traits => ['Array'], - is => 'ro', - isa => ArrayRef [Str], - required => 1, - default => sub { [] }, - auto_deref => 1, - handles => { '_add_api_method' => 'push' }, -); - -sub _build_meta_class { - my $self = shift; - return Moose::Meta::Class->create_anon_class( - superclasses => [ $self->method_metaclass ], - cache => 1, - ); -} +with qw/ + MooseX::Net::API::Meta::Method::APIMethod + MooseX::Net::API::Meta::Method::APIDeclare + /; 1; -- cgit 1.4.1 From 59536291a0e5687532a4b42a3302c4040db2bb5d Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 11:35:37 +0200 Subject: mx::net::api::method : attributes, wrapper, validates, ... --- lib/MooseX/Net/API/Meta/Method.pm | 209 ++++++++++++++++++++++++++++++++++++-- 1 file changed, 201 insertions(+), 8 deletions(-) (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API/Meta/Method.pm b/lib/MooseX/Net/API/Meta/Method.pm index e9ceca7..12001c4 100644 --- a/lib/MooseX/Net/API/Meta/Method.pm +++ b/lib/MooseX/Net/API/Meta/Method.pm @@ -1,19 +1,212 @@ package MooseX::Net::API::Meta::Method; use Moose; +use MooseX::Net::API::Error; +use MooseX::Types::Moose qw/Str Int ArrayRef/; + extends 'Moose::Meta::Method'; -has description => ( is => 'ro', isa => 'Str' ); -has path => ( is => 'ro', isa => 'Str', required => 1 ); -has method => ( is => 'ro', isa => 'Str', required => 1 ); -has params => ( is => 'ro', isa => 'ArrayRef', required => 0 ); -has required => ( is => 'ro', isa => 'ArrayRef', required => 0 ); -has expected => ( is => 'ro', isa => 'ArrayRef', required => 0 ); +use Moose::Util::TypeConstraints; + +subtype UriPath => as 'Str' => where { $_ =~ m!^/! } => + message {"path must start with /"}; + +enum 'Method' => qw(GET POST PUT DELETE); + +has description => (is => 'ro', isa => 'Str'); +has method => (is => 'ro', isa => 'Method', required => 1); +has path => (is => 'ro', isa => 'UriPath', required => 1, coerce => 1); +has params_in_url => (is => 'ro', isa => 'Bool', default => 0); +has authentication => (is => 'ro', isa => 'Bool', required => 0, default => 0); +has expected => ( + traits => ['Array'], + is => 'ro', + isa => ArrayRef [Int], + auto_deref => 1, + required => 0, + predicate => 'has_expected', + handles => {find_expected_code => 'grep',}, +); +has params => ( + traits => ['Array'], + is => 'ro', + isa => ArrayRef [Str], + required => 0, + default => sub { [] }, + auto_deref => 1, + handles => {find_param => 'first',} +); +has required => ( + traits => ['Array'], + is => 'ro', + isa => ArrayRef [Str], + default => sub { [] }, + auto_deref => 1, + required => 0, +); + +before wrap => sub { + my $class = shift; + my %args = @_; + + $class->_validate_params_before_install(\%args); + $class->_validate_required_before_install(\%args); +}; -sub new { +sub wrap { my $class = shift; my %args = @_; - $class->SUPER::wrap(@_); + + if (!defined $args{body}) { + my $code = sub { + my ($self, %method_args) = @_; + + my $method = + $self->meta->find_method_by_name($args{name}) + ->get_original_method; + + $method->_validate_before_execute(\%method_args); + + my $path = $method->build_path(\%method_args); + my $local_url = $method->build_uri($self, $path); + + my $result = $self->http_request( + $method->method => $local_url, + $method->params_in_url, \%method_args + ); + + my $code = $result->code; + + if ($method->has_expected + && !$method->find_expected_code(sub {/$code/})) + { + die MooseX::Net::API::Error->new( + reason => "unexpected code", + http_error => $result + ); + } + + my $content_type = $self->api_format + // $result->header('Content-Type'); + $content_type =~ s/(;.+)$//; + + my $content; + if ($result->is_success && $code != 204) { + my @deserialize_order = ($content_type, $self->api_format); + $content = + $self->deserialize($result->content, \@deserialize_order); + + if (!$content) { + die MooseX::Net::API::Error->new( + reason => "can't deserialize content", + http_error => $result, + ); + } + } + + if ($result->is_success) { + if (wantarray) { + return ($content, $result); + } + else { + return $content; + } + } + + die MooseX::Net::API::Error->new( + http_error => $result, + reason => $result->reason, + ); + }; + $args{body} = $code; + } + $class->SUPER::wrap(%args); +} + +sub _validate_params_before_install { + my ( $class, $args ) = @_; + if ( !$args->{params} && $args->{required} ) { + die MooseX::Net::API::Error->new( reason => + "You can't require a param that have not been declared" ); + } +} + +sub _validate_required_before_install { + my ( $class, $args ) = @_; + if ( $args->{required} ) { + foreach my $required ( @{ $args->{required} } ) { + die MooseX::Net::API::Error->new( reason => + "$required is required but is not declared in params" ) + if ( !grep { $_ eq $required } @{ $args->{params} } ); + } + } +} + +sub _validate_before_execute { + my ($self, $args) = @_; + for my $method (qw/check_params_before_run check_required_before_run/) { + $self->$method($args); + } +} + +sub check_params_before_run { + my ($self, $args) = @_; + + # check if there is no undeclared param + foreach my $arg (keys %$args) { + if (!$self->find_param(sub {/$arg/})) { + die MooseX::Net::API::Error->new( + reason => "'$arg' is not declared as a param"); + } + } +} + +sub check_required_before_run { + my ($self, $args) = @_; + + # check if all our params declared as required are present + foreach my $required ($self->required) { + if (!grep { $required eq $_ } keys %$args) { + die MooseX::Net::API::Error->new(reason => + "'$required' is declared as required, but is not present"); + } + } +} + +sub build_path { + my ($self, $args) = @_; + my $path = $self->path; + + my $max_iter = keys %$args; + my $i = 0; + while ($path =~ /(?:\$|:)(\w+)/g) { + my $match = $1; + $i++; + if (my $value = delete $args->{$match}) { + $path =~ s/(?:\$|:)$match/$value/; + } + if ($max_iter > $i) { + $path =~ s/(?:\$|:)(\w+)//; + } + } + return $path; +} + +sub build_uri { + my ($method, $self, $path) = @_; + + my $local_url = $self->api_base_url->clone; + my $path_url_base = $local_url->path; + $path_url_base =~ s/\/$// if $path_url_base =~ m!/$!; + $path_url_base .= $path; + + if ($self->api_format && $self->api_format_mode eq 'append') { + my $format = $self->api_format; + $path_url_base .= "." . $format; + } + + $local_url->path($path_url_base); + return $local_url; } 1; -- cgit 1.4.1 From 044f1054e38474d687df9a1e98c94f24582a663c Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 11:35:59 +0200 Subject: move code to roles --- lib/MooseX/Net/API/Meta/Method/APIDeclare.pm | 49 ++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 lib/MooseX/Net/API/Meta/Method/APIDeclare.pm (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm b/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm new file mode 100644 index 0000000..4ad5150 --- /dev/null +++ b/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm @@ -0,0 +1,49 @@ +package MooseX::Net::API::Meta::Method::APIDeclare; + +use Moose::Role; +use MooseX::Net::API::Error; + +has options => ( + is => 'ro', + traits => ['Hash'], + isa => 'HashRef[Str|CodeRef]', + default => sub { {} }, + lazy => 1, + handles => { + set_option => 'set', + get_option => 'get', + }, +); + +sub add_net_api_declare { + my ($meta, $name, %options) = @_; + + if ($options{useragent}) { + die MooseX::Net::API::Error->new( + reason => "'useragent' must be a CODE ref") + unless ref $options{useragent} eq 'CODE'; + $meta->set_option(useragent => delete $options{useragent}); + } + + # XXX custom authentication_method (replace with before request !) + + # XXX for backward compatibility + for my $attr (qw/base_url format username password/) { + my $attr_name = "api_" . $attr; + if (exists $options{$attr} && !exists $options{$attr_name}) { + $options{$attr_name} = delete $options{$attr}; + } + } + + for my $attr (qw/api_base_url api_format api_username api_password authentication/) { + $meta->set_option($attr => $options{$attr}) if defined $options{$attr}; + } + + # XXX before_request after_request + + if (keys %options) { + # XXX croak + } +} + +1; -- cgit 1.4.1 From 54b15b8276e20b2ce6863ed65f6abf4963ccc363 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 11:36:25 +0200 Subject: remove code, let the wrapper do the work --- lib/MooseX/Net/API/Meta/Method/APIMethod.pm | 59 +++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+) create mode 100644 lib/MooseX/Net/API/Meta/Method/APIMethod.pm (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API/Meta/Method/APIMethod.pm b/lib/MooseX/Net/API/Meta/Method/APIMethod.pm new file mode 100644 index 0000000..b1d0777 --- /dev/null +++ b/lib/MooseX/Net/API/Meta/Method/APIMethod.pm @@ -0,0 +1,59 @@ +package MooseX::Net::API::Meta::Method::APIMethod; + +use Moose::Role; +use MooseX::Net::API::Error; +use MooseX::Net::API::Meta::Method; +use MooseX::Types::Moose qw/Str ArrayRef/; + +has local_api_methods => ( + traits => ['Array'], + is => 'ro', + isa => ArrayRef [Str], + required => 1, + default => sub { [] }, + auto_deref => 1, + handles => { + _get_api_method => 'grep', + _add_api_method => 'push', + _all_api_methods => 'elements', + }, +); + +before add_net_api_method => sub { + my ($meta, $name) = @_; + if (my @method = $meta->_get_api_method(sub {/^$name$/})) { + die MooseX::Net::API::Error->new( + reason => "method '$name' is already declared in " . $meta->name); + } +}; + +sub add_net_api_method { + my ($meta, $name, %options) = @_; + + my $code = delete $options{code}; + $meta->add_method( + $name, + MooseX::Net::API::Meta::Method->wrap( + name => $name, + package_name => $meta->name, + body => $code, + %options + ), + ); + $meta->_add_api_method($name); +} + +after add_net_api_method => sub { + my ($meta, $name, %options) = @_; + $meta->add_before_method_modifier( + $name, + sub { + my $self = shift; + die MooseX::Net::API::Error->new( + reason => "'api_base_url' have not been defined") + unless $self->api_base_url; + } + ); +}; + +1; -- cgit 1.4.1 From d817af5411ef2b7592e4b4f3da466e2e05fe365e Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 11:36:46 +0200 Subject: parser to (de)serialize content --- lib/MooseX/Net/API/Parser.pm | 8 ++++++++ lib/MooseX/Net/API/Parser/JSON.pm | 17 +++++++++++++++++ lib/MooseX/Net/API/Parser/XML.pm | 24 ++++++++++++++++++++++++ lib/MooseX/Net/API/Parser/YAML.pm | 17 +++++++++++++++++ 4 files changed, 66 insertions(+) create mode 100644 lib/MooseX/Net/API/Parser.pm create mode 100644 lib/MooseX/Net/API/Parser/JSON.pm create mode 100644 lib/MooseX/Net/API/Parser/XML.pm create mode 100644 lib/MooseX/Net/API/Parser/YAML.pm (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API/Parser.pm b/lib/MooseX/Net/API/Parser.pm new file mode 100644 index 0000000..d33d857 --- /dev/null +++ b/lib/MooseX/Net/API/Parser.pm @@ -0,0 +1,8 @@ +package MooseX::Net::API::Parser; + +use Moose; + +sub encode {die "must be implemented"} +sub decode {die "must be implemented"} + +1; diff --git a/lib/MooseX/Net/API/Parser/JSON.pm b/lib/MooseX/Net/API/Parser/JSON.pm new file mode 100644 index 0000000..4711a8a --- /dev/null +++ b/lib/MooseX/Net/API/Parser/JSON.pm @@ -0,0 +1,17 @@ +package MooseX::Net::API::Parser::JSON; + +use JSON; +use Moose; +extends 'MooseX::Net::API::Parser'; + +sub encode { + my ($self, $content) = @_; + return JSON::encode_json($content); +} + +sub decode { + my ($self, $content) = @_; + return JSON::decode_json($content); +} + +1; diff --git a/lib/MooseX/Net/API/Parser/XML.pm b/lib/MooseX/Net/API/Parser/XML.pm new file mode 100644 index 0000000..f831cf1 --- /dev/null +++ b/lib/MooseX/Net/API/Parser/XML.pm @@ -0,0 +1,24 @@ +package MooseX::Net::API::Parser::XML; + +use XML::Simple; +use Moose; +extends 'MooseX::Net::API::Parser'; + +has _xml_parser( + is => 'rw', + isa => 'XML::Simple', + lazy => 1, + default => sub { XML::SImple->new(ForceArray => 0) } +); + +sub encode { + my ($self, $content) = @_; + return $self->_xml_parser->XMLin($content); +} + +sub decode { + my ($self, $content) = @_; + return $self->_xml_parser->XMLout($content); +} + +1; diff --git a/lib/MooseX/Net/API/Parser/YAML.pm b/lib/MooseX/Net/API/Parser/YAML.pm new file mode 100644 index 0000000..f359831 --- /dev/null +++ b/lib/MooseX/Net/API/Parser/YAML.pm @@ -0,0 +1,17 @@ +package MooseX::Net::API::Parser::YAML; + +use YAML::Syck; +use Moose; +extends 'MooseX::Net::API::Parser'; + +sub encode { + my ($self, $content) = @_; + return Dump($content); +} + +sub decode { + my ($self, $content) = @_; + return Load($content); +} + +1; -- cgit 1.4.1 From 0ce9554937e19d7c0045a68bc0c4184c84c236c4 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 11:37:02 +0200 Subject: role to handle useragent --- lib/MooseX/Net/API/Role/UserAgent.pm | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 lib/MooseX/Net/API/Role/UserAgent.pm (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API/Role/UserAgent.pm b/lib/MooseX/Net/API/Role/UserAgent.pm new file mode 100644 index 0000000..0c11732 --- /dev/null +++ b/lib/MooseX/Net/API/Role/UserAgent.pm @@ -0,0 +1,24 @@ +package MooseX::Net::API::Role::UserAgent; + +use Moose::Role; +use LWP::UserAgent; + +has api_useragent => ( + is => 'rw', + isa => 'LWP::UserAgent', + lazy => 1, + default => sub { + my $self = shift; + my $ua = $self->meta->get_option('useragent'); + return $ua->() if $ua; + $ua = LWP::UserAgent->new(); + $ua->agent( + "MooseX::Net::API " . $MooseX::Net::API::VERSION . " (Perl)"); + $ua->env_proxy; + return $ua; + } +); + +1; + +__END__ -- cgit 1.4.1 From a2634d1eb978366d85a9b55153a90bd001950933 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 11:37:31 +0200 Subject: role to handle format informations --- lib/MooseX/Net/API/Role/Format.pm | 41 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 lib/MooseX/Net/API/Role/Format.pm (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API/Role/Format.pm b/lib/MooseX/Net/API/Role/Format.pm new file mode 100644 index 0000000..32dbc98 --- /dev/null +++ b/lib/MooseX/Net/API/Role/Format.pm @@ -0,0 +1,41 @@ +package MooseX::Net::API::Role::Format; + +use Moose::Role; +use Moose::Util::TypeConstraints; + +sub content_type { + { json => {value => 'application/json', module => 'JSON',}, + yaml => {value => 'text/x-yaml', module => 'YAML'}, + xml => {value => 'text/xml', module => 'XML::Simple'}, + }; +} + +subtype Format => as 'Str' => where { + my $format = shift; + grep {/^$format$/} keys %{content_type()}; +}; + +enum 'FormatMode' => qw(content-type append); + +has api_format => ( + is => 'rw', + isa => 'Format', + lazy => 1, + default => sub { + my $self = shift; + $self->meta->get_option('api_format'); + } +); + +has api_format_mode => ( + is => 'rw', + isa => 'FormatMode', + lazy => 1, + default => sub { + my $self = shift; + my $mode = $self->meta->get_option('api_format_mode'); + $mode || 'append'; + } +); + +1; -- cgit 1.4.1 From 44e876662f72e88e5bd40c433a14e749d3ad5fdc Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 11:37:49 +0200 Subject: http_request and api_base_url are defined in this role --- lib/MooseX/Net/API/Role/Request.pm | 52 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) create mode 100644 lib/MooseX/Net/API/Role/Request.pm (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API/Role/Request.pm b/lib/MooseX/Net/API/Role/Request.pm new file mode 100644 index 0000000..eabb32d --- /dev/null +++ b/lib/MooseX/Net/API/Role/Request.pm @@ -0,0 +1,52 @@ +package MooseX::Net::API::Role::Request; + +use Moose::Role; +use HTTP::Request; +use MooseX::Net::API::Error; +use MooseX::Types::URI qw(Uri); + +has api_base_url => ( + is => 'rw', + isa => Uri, + coerce => 1, + lazy => 1, + default => sub { + my $self = shift; + my $api_base_url = $self->meta->get_option('api_base_url'); + if (!$api_base_url) { + die MooseX::Net::API::Error->new( + reason => "'api_base_url' have not been defined"); + } + $api_base_url; + } +); + +sub http_request { + my ($self, $method, $uri, $params_in_url, $args) = @_; + + my $request; + + if ( $method =~ /^(?:GET|DELETE)$/ || $params_in_url ) { + $uri->query_form(%$args); + $request = HTTP::Request->new( $method => $uri ); + } + elsif ( $method =~ /^(?:POST|PUT)$/ ) { + $request = HTTP::Request->new( $method => $uri ); + my $content = $self->serialize($args); + $request->content($content); + } + else { + die MooseX::Net::API::Error->new( + reason => "$method is not defined" ); + } + + $request->header( + 'Content-Type' => $self->content_type->{$self->api_format}->{value}) + if $self->api_format_mode eq 'content-type'; + + # XXX lwp hook! + my $result = $self->api_useragent->request($request); + return $result; +} + +1; -- cgit 1.4.1 From 1c4c26d1a82b81df4571568b21d919418f3355fa Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 11:38:07 +0200 Subject: use MX::Net::API::Parser to handle serialization --- lib/MooseX/Net/API/Role/Serialization.pm | 48 ++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 lib/MooseX/Net/API/Role/Serialization.pm (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API/Role/Serialization.pm b/lib/MooseX/Net/API/Role/Serialization.pm new file mode 100644 index 0000000..b36955c --- /dev/null +++ b/lib/MooseX/Net/API/Role/Serialization.pm @@ -0,0 +1,48 @@ +package MooseX::Net::API::Role::Serialization; + +use Try::Tiny; +use Moose::Role; + +has serializers => ( + traits => ['Hash'], + is => 'rw', + isa => 'HashRef[MooseX::Net::API::Parser]', + default => sub { {} }, + auto_deref => 1, + handles => { + _add_serializer => 'set', + _get_serializer => 'get', + }, +); + +sub deserialize { + my ($self, $content, $list_of_formats) = @_; + + foreach my $format (@$list_of_formats) { + my $s = $self->_get_serializer($format) + || $self->_load_serializer($format); + next unless $s; + my $result = try { $s->decode($content) }; + return $result if $result; + } +} + +sub serialize { + my ($self, $content) = @_; + my $s = $self->_get_serializer($self->api_format); + my $result = try { $s->encode($content) }; + return $result if $result; +} + +sub _load_serializer { + my $self = shift; + my $format = shift || $self->api_format; + my $parser = "MooseX::Net::API::Parser::" . uc($format); + if (Class::MOP::load_class($parser)) { + my $o = $parser->new; + $self->_add_serializer($format => $o); + return $o; + } +} + +1; -- cgit 1.4.1 From b9d5222b73faf3577833008e32d55d16d5e4818b Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 11:52:22 +0200 Subject: move content deserialization to role --- lib/MooseX/Net/API/Meta/Method.pm | 34 +++++++++----------------------- lib/MooseX/Net/API/Role/Serialization.pm | 24 ++++++++++++++++++++++ 2 files changed, 33 insertions(+), 25 deletions(-) (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API/Meta/Method.pm b/lib/MooseX/Net/API/Meta/Method.pm index 12001c4..03e0612 100644 --- a/lib/MooseX/Net/API/Meta/Method.pm +++ b/lib/MooseX/Net/API/Meta/Method.pm @@ -67,8 +67,8 @@ sub wrap { $method->_validate_before_execute(\%method_args); - my $path = $method->build_path(\%method_args); - my $local_url = $method->build_uri($self, $path); + my $path = $method->_build_path(\%method_args); + my $local_url = $method->_build_uri($self, $path); my $result = $self->http_request( $method->method => $local_url, @@ -76,7 +76,7 @@ sub wrap { ); my $code = $result->code; - + if ($method->has_expected && !$method->find_expected_code(sub {/$code/})) { @@ -86,23 +86,7 @@ sub wrap { ); } - my $content_type = $self->api_format - // $result->header('Content-Type'); - $content_type =~ s/(;.+)$//; - - my $content; - if ($result->is_success && $code != 204) { - my @deserialize_order = ($content_type, $self->api_format); - $content = - $self->deserialize($result->content, \@deserialize_order); - - if (!$content) { - die MooseX::Net::API::Error->new( - reason => "can't deserialize content", - http_error => $result, - ); - } - } + my $content = $self->get_content($result);; if ($result->is_success) { if (wantarray) { @@ -144,12 +128,12 @@ sub _validate_required_before_install { sub _validate_before_execute { my ($self, $args) = @_; - for my $method (qw/check_params_before_run check_required_before_run/) { + for my $method (qw/_check_params_before_run _check_required_before_run/) { $self->$method($args); } } -sub check_params_before_run { +sub _check_params_before_run { my ($self, $args) = @_; # check if there is no undeclared param @@ -161,7 +145,7 @@ sub check_params_before_run { } } -sub check_required_before_run { +sub _check_required_before_run { my ($self, $args) = @_; # check if all our params declared as required are present @@ -173,7 +157,7 @@ sub check_required_before_run { } } -sub build_path { +sub _build_path { my ($self, $args) = @_; my $path = $self->path; @@ -192,7 +176,7 @@ sub build_path { return $path; } -sub build_uri { +sub _build_uri { my ($method, $self, $path) = @_; my $local_url = $self->api_base_url->clone; diff --git a/lib/MooseX/Net/API/Role/Serialization.pm b/lib/MooseX/Net/API/Role/Serialization.pm index b36955c..b813b03 100644 --- a/lib/MooseX/Net/API/Role/Serialization.pm +++ b/lib/MooseX/Net/API/Role/Serialization.pm @@ -1,7 +1,10 @@ package MooseX::Net::API::Role::Serialization; +use 5.010; + use Try::Tiny; use Moose::Role; +use MooseX::Net::API::Error; has serializers => ( traits => ['Hash'], @@ -15,6 +18,27 @@ has serializers => ( }, ); +sub get_content { + my ($self, $result) = @_; + + my $content_type = $self->api_format // $result->header('Content-Type'); + $content_type =~ s/(;.+)$//; + + my $content; + if ($result->is_success && $result->code != 204) { + my @deserialize_order = ($content_type, $self->api_format); + $content = $self->deserialize($result->content, \@deserialize_order); + + if (!$content) { + die MooseX::Net::API::Error->new( + reason => "can't deserialize content", + http_error => $result, + ); + } + } + $content; +} + sub deserialize { my ($self, $content, $list_of_formats) = @_; -- cgit 1.4.1 From a86d71f615e207fe82cd5866d7d8f2d3abc842f1 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 13:23:37 +0200 Subject: remove old serilizer --- lib/MooseX/Net/API/Role/Serialize.pm | 34 ---------------------------------- 1 file changed, 34 deletions(-) delete mode 100644 lib/MooseX/Net/API/Role/Serialize.pm (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API/Role/Serialize.pm b/lib/MooseX/Net/API/Role/Serialize.pm deleted file mode 100644 index f527928..0000000 --- a/lib/MooseX/Net/API/Role/Serialize.pm +++ /dev/null @@ -1,34 +0,0 @@ -package MooseX::Net::API::Role::Serialize; - -use Moose::Role; -use JSON::XS; -use YAML::Syck; -use XML::Simple; -use Try::Tiny; - -sub _to_json { - return encode_json( $_[1] ); -} - -sub _to_yaml { - return Dump $_[1]; -} - -sub _to_xml { - my $xml = XML::Simple->new( ForceArray => 0 ); - $xml->XMLin("$_[0]"); -} - -sub _do_serialization { - my ( $caller, $content, $format ) = @_; - - my $format_content; - my $method = '_to_' . $format; - return if ( !$caller->meta->find_method_by_name($method) ); - try { - $format_content = $caller->$method($content); - }; - return $format_content if $format_content; -} - -1; -- cgit 1.4.1 From 116a0371e2b42e7939653e5cc79435dd2ec78378 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 13:24:38 +0200 Subject: fix version number --- lib/MooseX/Net/API.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API.pm b/lib/MooseX/Net/API.pm index b0e02b8..ff0494d 100644 --- a/lib/MooseX/Net/API.pm +++ b/lib/MooseX/Net/API.pm @@ -3,7 +3,7 @@ package MooseX::Net::API; use Moose; use Moose::Exporter; -our $VERSION = '0.13'; +our $VERSION = '0.11'; Moose::Exporter->setup_import_methods( with_meta => [qw/net_api_method net_api_declare/], -- cgit 1.4.1 From 3f3ff5052101e26eb4c35c61637951f97b284c49 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 13:24:52 +0200 Subject: clean --- lib/MooseX/Net/API/Meta/Method.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API/Meta/Method.pm b/lib/MooseX/Net/API/Meta/Method.pm index 03e0612..3f77d08 100644 --- a/lib/MooseX/Net/API/Meta/Method.pm +++ b/lib/MooseX/Net/API/Meta/Method.pm @@ -2,12 +2,12 @@ package MooseX::Net::API::Meta::Method; use Moose; use MooseX::Net::API::Error; +use Moose::Util::TypeConstraints; + use MooseX::Types::Moose qw/Str Int ArrayRef/; extends 'Moose::Meta::Method'; -use Moose::Util::TypeConstraints; - subtype UriPath => as 'Str' => where { $_ =~ m!^/! } => message {"path must start with /"}; @@ -104,6 +104,7 @@ sub wrap { }; $args{body} = $code; } + $class->SUPER::wrap(%args); } -- cgit 1.4.1 From 6b5a00cab381d5ed55d662be44b67112e13fbb1c Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 18:56:01 +0200 Subject: clean code --- lib/MooseX/Net/API/Meta/Method/APIDeclare.pm | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm b/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm index 4ad5150..b65ef41 100644 --- a/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm +++ b/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm @@ -14,6 +14,22 @@ has options => ( get_option => 'get', }, ); +has accepted_options => ( + is => 'ro', + traits => ['Array'], + isa => 'ArrayRef[Str]', + default => sub { + [ qw/api_base_url + api_format + api_useranem + api_password + authentication + authentication_method/ + ]; + }, + lazy => 1, + auto_deref => 1, +); sub add_net_api_declare { my ($meta, $name, %options) = @_; @@ -25,8 +41,6 @@ sub add_net_api_declare { $meta->set_option(useragent => delete $options{useragent}); } - # XXX custom authentication_method (replace with before request !) - # XXX for backward compatibility for my $attr (qw/base_url format username password/) { my $attr_name = "api_" . $attr; @@ -35,15 +49,11 @@ sub add_net_api_declare { } } - for my $attr (qw/api_base_url api_format api_username api_password authentication/) { + for my $attr ($meta->accepted_options) { $meta->set_option($attr => $options{$attr}) if defined $options{$attr}; } # XXX before_request after_request - - if (keys %options) { - # XXX croak - } } 1; -- cgit 1.4.1 From 223e96504478e507e4d8e1627cb748fd4ec1c14b Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 18:56:12 +0200 Subject: handle authentication --- lib/MooseX/Net/API/Role/Authentication.pm | 47 +++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 lib/MooseX/Net/API/Role/Authentication.pm (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API/Role/Authentication.pm b/lib/MooseX/Net/API/Role/Authentication.pm new file mode 100644 index 0000000..6c38641 --- /dev/null +++ b/lib/MooseX/Net/API/Role/Authentication.pm @@ -0,0 +1,47 @@ +package MooseX::Net::API::Role::Authentication; + +use Moose::Role; + +has api_username => ( + is => 'rw', + isa => 'Str', + predicate => 'has_api_username', +); + +has api_password => ( + is => 'rw', + isa => 'Str', + predicate => 'has_api_password', +); + +# ugly :( +after BUILDALL => sub { + my $self = shift; + + for (qw/api_username api_password/) { + my $predicate = 'has_' . $_; + my $value = $self->meta->get_option($_); + $self->$_($value) if $value && !$self->$predicate; + } + + if (my $has_auth = $self->meta->get_option('authentication')) { + my $auth_method = $self->meta->get_option('authentication_method'); + if ($auth_method) { + $self->api_useragent->add_handler( + request_prepare => sub { $self->$auth_method(@_) }); + } + else { + if ($self->has_api_username && $self->has_api_password) { + $self->api_useragent->add_handler( + request_prepare => sub { + my $req = shift; + $req->headers->authorization_basic($self->api_username, + $self->api_password); + } + ); + } + } + } +}; + +1; -- cgit 1.4.1 From fdb180a73f97d5a1456d5ac3d0a5a844e22d0ea9 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Thu, 3 Jun 2010 08:34:13 +0200 Subject: http-console: a simple http console to do REST query (like http://github.com/cloudhead/http-console) --- bin/http-console | 46 +++++++++++++++++++++++++++++ lib/MooseX/Net/API/Meta/Method.pm | 2 +- lib/MooseX/Net/API/Meta/Method/APIMethod.pm | 1 + 3 files changed, 48 insertions(+), 1 deletion(-) create mode 100644 bin/http-console (limited to 'lib/MooseX/Net') diff --git a/bin/http-console b/bin/http-console new file mode 100644 index 0000000..6f0e1f8 --- /dev/null +++ b/bin/http-console @@ -0,0 +1,46 @@ +use strict; +use warnings; +use 5.010; +use Term::ReadLine; + +use Getopt::Long; +use YAML::Syck; + +my $url = shift; +my $format_mode = 'append'; +my $format = 'json'; + +GetOptions( + 'm=s' => \$format_mode, + 'f=s' => \$format, +); + +package http::net::console; +use MooseX::Net::API; + +package main; + +my ($content, $result); + +my $term = Term::ReadLine->new("http::net::console"); +my $prompt = $url . '> '; +while (defined(my $in = $term->readline($prompt))) { + if ($in =~ /^(GET|PUT|POST|DELETE)\s(.*)$/) { + my $http_console = + http::net::console->new(api_base_url => $url, api_format => $format, api_format_mode => $format_mode); + $http_console->meta->add_net_api_method( + 'anonymous', + method => $1, + path => $2 + ); + ($content, $result) = $http_console->anonymous; + say $result->content; + } + if ($in eq 'show headers') { + if (defined $result) { + say Dump $result->headers; + }else{ + say "no headers to show"; + } + } +} diff --git a/lib/MooseX/Net/API/Meta/Method.pm b/lib/MooseX/Net/API/Meta/Method.pm index 3f77d08..bb29a97 100644 --- a/lib/MooseX/Net/API/Meta/Method.pm +++ b/lib/MooseX/Net/API/Meta/Method.pm @@ -99,7 +99,7 @@ sub wrap { die MooseX::Net::API::Error->new( http_error => $result, - reason => $result->reason, + reason => $result->message, ); }; $args{body} = $code; diff --git a/lib/MooseX/Net/API/Meta/Method/APIMethod.pm b/lib/MooseX/Net/API/Meta/Method/APIMethod.pm index b1d0777..8185522 100644 --- a/lib/MooseX/Net/API/Meta/Method/APIMethod.pm +++ b/lib/MooseX/Net/API/Meta/Method/APIMethod.pm @@ -30,6 +30,7 @@ before add_net_api_method => sub { sub add_net_api_method { my ($meta, $name, %options) = @_; + # accept blessed method my $code = delete $options{code}; $meta->add_method( $name, -- cgit 1.4.1 From d66a559824e567e3f4f946a8616d99cdb59a11a9 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Thu, 3 Jun 2010 09:25:21 +0200 Subject: update POD --- lib/MooseX/Net/API.pm | 106 ++++++++++++++++++++++++++++++++++++++------------ 1 file changed, 82 insertions(+), 24 deletions(-) (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API.pm b/lib/MooseX/Net/API.pm index ff0494d..b6f0f28 100644 --- a/lib/MooseX/Net/API.pm +++ b/lib/MooseX/Net/API.pm @@ -110,10 +110,53 @@ MooseX::Net::API - Easily create client for net API =head1 DESCRIPTION MooseX::Net::API is a module to help to easily create a client for a web API. + This module is heavily inspired by what L does. B +The following roles are added to your class: + +=over 4 + +=item B + +=item B + +=item B + +=item B + +=item B + +=back + +The following attributes are added to your class: + +=over 4 + +=item B + +=item B + +=item B + +=item B + +=item B + +=item B + +=back + +The following methods are added to your class: + +=over 4 + +=item B + +=back + =head2 METHODS =over 4 @@ -130,17 +173,37 @@ B =item B -The base url for all the API's calls. This will add an B attribut to your class. Can be set at the object creation or before calling an API method. If no api_base_url is defined, the method will die. +The base url for all the API's calls. This will set the B attribut in your class. Can be set at the object creation or before calling an API method. + +=item B + +The format for the API's calls. This will set the B attribut to your class. Value can be: + +=over 2 + +=item B -=item B (required, must be either xml, json or yaml) +=item B -The format for the API's calls. This will add an B attribut to your class. +=item B -=item B (required, must be 'append' or 'content-type') +=back + +=item B + +How the format is handled. B will add B<.$format> to the query, B will set the content-type information to the header of the request. Should be one the following value: -How the format is handled. B will add B<.json> to the query, B will add the content-type information to the header of the request. +=over 2 + +=item B -=item B (optional, by default it's a LWP::UserAgent object) +=item B + +=back + +=item B + +A L object. useragent => sub { my $ua = LWP::UserAgent->new; @@ -148,11 +211,11 @@ How the format is handled. B will add B<.json> to the query, B (optional) +=item B This is a boolean to tell if we must authenticate to use this API. -=item B (optional) +=item B The default authentication method only set an authorization header using the Basic Authentication Scheme. You can write your own authentication method: @@ -165,7 +228,6 @@ The default authentication method only set an authorization header using the Bas sub my_auth_method { my ($self, $req) = @_; #$req is an HTTP::Request object ... - return $req; } =back @@ -174,15 +236,15 @@ The default authentication method only set an authorization header using the Bas =over 2 -=item B [string] +=item B -description of the method (this is a documentation) +A string to describe the method (this is a documentation) -=item B [string] +=item B HTTP method (GET, POST, PUT, DELETE) -=item B [string] +=item B path of the query. @@ -190,7 +252,7 @@ If you defined your path and params like this net_api_method user_comments => ( ... - path => '/user/$user/list/$date/', + path => '/user/:user/list/:date', params => [qw/user date foo bar/], ... ); @@ -199,23 +261,19 @@ and you call $obj->user_comments(user => 'franck', date => 'today', foo => 1, bar => 2); -the url generetad will look like +the url generated will look like /user/franck/list/today/?foo=1&bar=2 -=item B [arrayref] - -list of params. - -=item B [arrayref] +=item B -list of required params. +Arrayref of params. -=item B (optional) +=item B -should we do an authenticated call +Arrayref of required params. -=item B (optional) +=item B When you do a post, the content may have to be sent as arguments in the url, and not as content in the header. -- cgit 1.4.1 From b62c50ed3c9b48d7d964134de5f4ef0fd36a6112 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Thu, 3 Jun 2010 09:50:39 +0200 Subject: update POD --- lib/MooseX/Net/API.pm | 12 +++++-- lib/MooseX/Net/API/Error.pm | 1 - lib/MooseX/Net/API/Meta/Class.pm | 26 +++++++++++++++ lib/MooseX/Net/API/Meta/Method.pm | 32 ++++++++++++++++-- lib/MooseX/Net/API/Meta/Method/APIDeclare.pm | 28 +++++++++++++++- lib/MooseX/Net/API/Meta/Method/APIMethod.pm | 26 +++++++++++++++ lib/MooseX/Net/API/Parser.pm | 27 +++++++++++++++ lib/MooseX/Net/API/Parser/JSON.pm | 26 +++++++++++++++ lib/MooseX/Net/API/Parser/XML.pm | 26 +++++++++++++++ lib/MooseX/Net/API/Parser/YAML.pm | 26 +++++++++++++++ lib/MooseX/Net/API/Role/Authentication.pm | 36 ++++++++++++++++++++ lib/MooseX/Net/API/Role/Deserialize.pm | 49 ---------------------------- lib/MooseX/Net/API/Role/Format.pm | 44 +++++++++++++++++++++++++ lib/MooseX/Net/API/Role/Request.pm | 42 ++++++++++++++++++++++++ lib/MooseX/Net/API/Role/Serialization.pm | 46 ++++++++++++++++++++++++++ lib/MooseX/Net/API/Role/UserAgent.pm | 34 ++++++++++++++++++- 16 files changed, 424 insertions(+), 57 deletions(-) delete mode 100644 lib/MooseX/Net/API/Role/Deserialize.pm (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API.pm b/lib/MooseX/Net/API.pm index b6f0f28..2dcfc13 100644 --- a/lib/MooseX/Net/API.pm +++ b/lib/MooseX/Net/API.pm @@ -72,11 +72,11 @@ MooseX::Net::API - Easily create client for net API ); # declaring a users method - # calling $obj->users will call http://exemple.com/api/users?country=france + # calling $obj->users will call http://exemple.com/api/users/france net_api_method users => ( description => 'this get a list of users', method => 'GET', - path => '/users/', + path => '/users/:country', params => [qw/country/], ); @@ -155,6 +155,14 @@ The following methods are added to your class: =item B +=item B + +=item B + +=item B + +=item B + =back =head2 METHODS diff --git a/lib/MooseX/Net/API/Error.pm b/lib/MooseX/Net/API/Error.pm index a710205..8825877 100644 --- a/lib/MooseX/Net/API/Error.pm +++ b/lib/MooseX/Net/API/Error.pm @@ -29,7 +29,6 @@ sub error { } 1; - __END__ =head1 NAME diff --git a/lib/MooseX/Net/API/Meta/Class.pm b/lib/MooseX/Net/API/Meta/Class.pm index 376578d..9fdd793 100644 --- a/lib/MooseX/Net/API/Meta/Class.pm +++ b/lib/MooseX/Net/API/Meta/Class.pm @@ -8,3 +8,29 @@ with qw/ /; 1; +__END__ + +=head1 NAME + +MooseX::Net::API::Meta::Class + +=head1 SYNOPSIS + +=head1 DESCRIPTION + +=head1 AUTHOR + +franck cuny Efranck@lumberjaph.netE + +=head1 SEE ALSO + +=head1 LICENSE + +Copyright 2009, 2010 by Linkfluence + +http://linkfluence.net + +This library is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut diff --git a/lib/MooseX/Net/API/Meta/Method.pm b/lib/MooseX/Net/API/Meta/Method.pm index bb29a97..7c388b9 100644 --- a/lib/MooseX/Net/API/Meta/Method.pm +++ b/lib/MooseX/Net/API/Meta/Method.pm @@ -11,13 +11,13 @@ extends 'Moose::Meta::Method'; subtype UriPath => as 'Str' => where { $_ =~ m!^/! } => message {"path must start with /"}; -enum 'Method' => qw(GET POST PUT DELETE); +enum Method => qw(GET POST PUT DELETE); has description => (is => 'ro', isa => 'Str'); has method => (is => 'ro', isa => 'Method', required => 1); has path => (is => 'ro', isa => 'UriPath', required => 1, coerce => 1); -has params_in_url => (is => 'ro', isa => 'Bool', default => 0); -has authentication => (is => 'ro', isa => 'Bool', required => 0, default => 0); +has params_in_url => (is => 'ro', isa => 'Bool', default => 0); +has authentication => (is => 'ro', isa => 'Bool', default => 0); has expected => ( traits => ['Array'], is => 'ro', @@ -195,3 +195,29 @@ sub _build_uri { } 1; +__END__ + +=head1 NAME + +MooseX::Net::API::Meta::Class::Method + +=head1 SYNOPSIS + +=head1 DESCRIPTION + +=head1 AUTHOR + +franck cuny Efranck@lumberjaph.netE + +=head1 SEE ALSO + +=head1 LICENSE + +Copyright 2009, 2010 by Linkfluence + +http://linkfluence.net + +This library is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut diff --git a/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm b/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm index b65ef41..14fb83d 100644 --- a/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm +++ b/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm @@ -21,7 +21,7 @@ has accepted_options => ( default => sub { [ qw/api_base_url api_format - api_useranem + api_username api_password authentication authentication_method/ @@ -57,3 +57,29 @@ sub add_net_api_declare { } 1; +__END__ + +=head1 NAME + +MooseX::Net::API::Meta::Class::Method::APIDeclare + +=head1 SYNOPSIS + +=head1 DESCRIPTION + +=head1 AUTHOR + +franck cuny Efranck@lumberjaph.netE + +=head1 SEE ALSO + +=head1 LICENSE + +Copyright 2009, 2010 by Linkfluence + +http://linkfluence.net + +This library is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut diff --git a/lib/MooseX/Net/API/Meta/Method/APIMethod.pm b/lib/MooseX/Net/API/Meta/Method/APIMethod.pm index 8185522..d55fe82 100644 --- a/lib/MooseX/Net/API/Meta/Method/APIMethod.pm +++ b/lib/MooseX/Net/API/Meta/Method/APIMethod.pm @@ -58,3 +58,29 @@ after add_net_api_method => sub { }; 1; +__END__ + +=head1 NAME + +MooseX::Net::API::Meta::Class::Method::APIMethod + +=head1 SYNOPSIS + +=head1 DESCRIPTION + +=head1 AUTHOR + +franck cuny Efranck@lumberjaph.netE + +=head1 SEE ALSO + +=head1 LICENSE + +Copyright 2009, 2010 by Linkfluence + +http://linkfluence.net + +This library is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut diff --git a/lib/MooseX/Net/API/Parser.pm b/lib/MooseX/Net/API/Parser.pm index d33d857..8bf74b0 100644 --- a/lib/MooseX/Net/API/Parser.pm +++ b/lib/MooseX/Net/API/Parser.pm @@ -6,3 +6,30 @@ sub encode {die "must be implemented"} sub decode {die "must be implemented"} 1; + +__END__ + +=head1 NAME + +MooseX::Net::API::Parser + +=head1 SYNOPSIS + +=head1 DESCRIPTION + +=head1 AUTHOR + +franck cuny Efranck@lumberjaph.netE + +=head1 SEE ALSO + +=head1 LICENSE + +Copyright 2010 by Linkfluence + +http://linkfluence.net + +This library is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut diff --git a/lib/MooseX/Net/API/Parser/JSON.pm b/lib/MooseX/Net/API/Parser/JSON.pm index 4711a8a..bf4c08b 100644 --- a/lib/MooseX/Net/API/Parser/JSON.pm +++ b/lib/MooseX/Net/API/Parser/JSON.pm @@ -15,3 +15,29 @@ sub decode { } 1; +__END__ + +=head1 NAME + +MooseX::Net::API::Parser::JSON + +=head1 SYNOPSIS + +=head1 DESCRIPTION + +=head1 AUTHOR + +franck cuny Efranck@lumberjaph.netE + +=head1 SEE ALSO + +=head1 LICENSE + +Copyright 2010 by Linkfluence + +http://linkfluence.net + +This library is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut diff --git a/lib/MooseX/Net/API/Parser/XML.pm b/lib/MooseX/Net/API/Parser/XML.pm index f831cf1..8aee74f 100644 --- a/lib/MooseX/Net/API/Parser/XML.pm +++ b/lib/MooseX/Net/API/Parser/XML.pm @@ -22,3 +22,29 @@ sub decode { } 1; +__END__ + +=head1 NAME + +MooseX::Net::API::Parser::XML + +=head1 SYNOPSIS + +=head1 DESCRIPTION + +=head1 AUTHOR + +franck cuny Efranck@lumberjaph.netE + +=head1 SEE ALSO + +=head1 LICENSE + +Copyright 2010 by Linkfluence + +http://linkfluence.net + +This library is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut diff --git a/lib/MooseX/Net/API/Parser/YAML.pm b/lib/MooseX/Net/API/Parser/YAML.pm index f359831..5258796 100644 --- a/lib/MooseX/Net/API/Parser/YAML.pm +++ b/lib/MooseX/Net/API/Parser/YAML.pm @@ -15,3 +15,29 @@ sub decode { } 1; +__END__ + +=head1 NAME + +MooseX::Net::API::Parser::YAML + +=head1 SYNOPSIS + +=head1 DESCRIPTION + +=head1 AUTHOR + +franck cuny Efranck@lumberjaph.netE + +=head1 SEE ALSO + +=head1 LICENSE + +Copyright 2010 by Linkfluence + +http://linkfluence.net + +This library is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut diff --git a/lib/MooseX/Net/API/Role/Authentication.pm b/lib/MooseX/Net/API/Role/Authentication.pm index 6c38641..0b6de69 100644 --- a/lib/MooseX/Net/API/Role/Authentication.pm +++ b/lib/MooseX/Net/API/Role/Authentication.pm @@ -45,3 +45,39 @@ after BUILDALL => sub { }; 1; +__END__ + +=head1 NAME + +MooseX::Net::API::Role::Authentication + +=head1 SYNOPSIS + +=head1 DESCRIPTION + +=head2 ATTRIBUTES + +=over 4 + +=item B + +=item B + +=back + +=head1 AUTHOR + +franck cuny Efranck@lumberjaph.netE + +=head1 SEE ALSO + +=head1 LICENSE + +Copyright 2009, 2010 by Linkfluence + +http://linkfluence.net + +This library is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut diff --git a/lib/MooseX/Net/API/Role/Deserialize.pm b/lib/MooseX/Net/API/Role/Deserialize.pm deleted file mode 100644 index cf69087..0000000 --- a/lib/MooseX/Net/API/Role/Deserialize.pm +++ /dev/null @@ -1,49 +0,0 @@ -package MooseX::Net::API::Role::Deserialize; - -use Moose::Role; -use JSON::XS; -use YAML::Syck; -use XML::Simple; -use Try::Tiny; - -my $reverse_content_type = { - 'application/json' => 'json', - 'application/x-yaml' => 'yaml', - 'text/xml' => 'xml', - 'application/xml' => 'xml', -}; - -sub _from_json { - return decode_json( $_[1] ); -} - -sub _from_yaml { - return Load $_[1]; -} - -sub _from_xml { - my $xml = XML::Simple->new( ForceArray => 0 ); - $xml->XMLin( $_[1] ); -} - -sub _do_deserialization { - my ( $caller, $raw_content, @content_types ) = @_; - - my $content; - foreach my $deserializer (@content_types) { - my $method; - if ( $reverse_content_type->{$deserializer} ) { - $method = '_from_' . $reverse_content_type->{$deserializer}; - } - else { - $method = '_from_' . $deserializer; - } - next if ( !$caller->meta->find_method_by_name($method) ); - try { - $content = $caller->$method($raw_content); - }; - return $content if $content; - } -} - -1; diff --git a/lib/MooseX/Net/API/Role/Format.pm b/lib/MooseX/Net/API/Role/Format.pm index 32dbc98..e766161 100644 --- a/lib/MooseX/Net/API/Role/Format.pm +++ b/lib/MooseX/Net/API/Role/Format.pm @@ -39,3 +39,47 @@ has api_format_mode => ( ); 1; +__END__ + +=head1 NAME + +MooseX::Net::API::Role::Format + +=head1 SYNOPSIS + +=head1 DESCRIPTION + +=head2 METHODS + +=over 4 + +=item B + +=back + +=head2 ATTRIBUTES + +=over 4 + +=item B + +=item B + +=back + +=head1 AUTHOR + +franck cuny Efranck@lumberjaph.netE + +=head1 SEE ALSO + +=head1 LICENSE + +Copyright 2009, 2010 by Linkfluence + +http://linkfluence.net + +This library is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut diff --git a/lib/MooseX/Net/API/Role/Request.pm b/lib/MooseX/Net/API/Role/Request.pm index eabb32d..214411c 100644 --- a/lib/MooseX/Net/API/Role/Request.pm +++ b/lib/MooseX/Net/API/Role/Request.pm @@ -50,3 +50,45 @@ sub http_request { } 1; +__END__ + +=head1 NAME + +MooseX::Net::API::Role::Request + +=head1 SYNOPSIS + +=head1 DESCRIPTION + +=head2 METHODS + +=over 4 + +=item B + +=back + +=head2 ATTRIBUTES + +=over 4 + +=item B + +=back + +=head1 AUTHOR + +franck cuny Efranck@lumberjaph.netE + +=head1 SEE ALSO + +=head1 LICENSE + +Copyright 2009, 2010 by Linkfluence + +http://linkfluence.net + +This library is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut diff --git a/lib/MooseX/Net/API/Role/Serialization.pm b/lib/MooseX/Net/API/Role/Serialization.pm index b813b03..d4feb56 100644 --- a/lib/MooseX/Net/API/Role/Serialization.pm +++ b/lib/MooseX/Net/API/Role/Serialization.pm @@ -70,3 +70,49 @@ sub _load_serializer { } 1; +__END__ + +=head1 NAME + +MooseX::Net::API::Role::Serialization + +=head1 SYNOPSIS + +=head1 DESCRIPTION + +=head2 ATTRIBUTES + +=over 4 + +=item B + +=back + +=head2 METHODS + +=over 4 + +=item B + +=item B + +=item B + +=back + +=head1 AUTHOR + +franck cuny Efranck@lumberjaph.netE + +=head1 SEE ALSO + +=head1 LICENSE + +Copyright 2009, 2010 by Linkfluence + +http://linkfluence.net + +This library is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut diff --git a/lib/MooseX/Net/API/Role/UserAgent.pm b/lib/MooseX/Net/API/Role/UserAgent.pm index 0c11732..c3a1d5b 100644 --- a/lib/MooseX/Net/API/Role/UserAgent.pm +++ b/lib/MooseX/Net/API/Role/UserAgent.pm @@ -20,5 +20,37 @@ has api_useragent => ( ); 1; - __END__ + +=head1 NAME + +MooseX::Net::API::Role::UseAgent + +=head1 SYNOPSIS + +=head1 DESCRIPTION + +=head2 ATTRIBUTES + +=over 4 + +=item B + +=back + +=head1 AUTHOR + +franck cuny Efranck@lumberjaph.netE + +=head1 SEE ALSO + +=head1 LICENSE + +Copyright 2009, 2010 by Linkfluence + +http://linkfluence.net + +This library is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut -- cgit 1.4.1 From 76f2776bc147cc3077be947eef0effae9f5367f9 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Thu, 3 Jun 2010 09:59:27 +0200 Subject: fix attribute declaration --- lib/MooseX/Net/API/Parser/XML.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/MooseX/Net') diff --git a/lib/MooseX/Net/API/Parser/XML.pm b/lib/MooseX/Net/API/Parser/XML.pm index 8aee74f..7198175 100644 --- a/lib/MooseX/Net/API/Parser/XML.pm +++ b/lib/MooseX/Net/API/Parser/XML.pm @@ -4,7 +4,7 @@ use XML::Simple; use Moose; extends 'MooseX::Net::API::Parser'; -has _xml_parser( +has _xml_parser => ( is => 'rw', isa => 'XML::Simple', lazy => 1, -- cgit 1.4.1